Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two input field should not be empty while generating table #33

Closed
Siddheshjondhale opened this issue Oct 13, 2022 · 4 comments
Closed

Comments

@Siddheshjondhale
Copy link
Contributor

image

In the above Image I think there should be a condition given that when any one of the two input are kept empty then it should give a alert message. As we see in the above image the input field when are kept empty and we generate table then it puts empty columns. So I feel this needs to be fixed. Let me know what you think about it.

Kindly assign me this issue.

@LunarMarathon
Copy link
Owner

There's no form so required can't be used. Will the alert be styled or default?

@Siddheshjondhale
Copy link
Contributor Author

I was thinking a styled alert. Which one would you prefer? Styled or default let me know so I can contribute to it.

@LunarMarathon
Copy link
Owner

A styled one please! I've made UI changes so please use the new color palette in the CSS file. The search button needs it too btw but only checking for the first i/p is enough. The second i/p isn't require for search. Let me know if you have a rough design (or else it's a headache while reviewing) Thanks!

@Siddheshjondhale
Copy link
Contributor Author

Siddheshjondhale commented Oct 15, 2022

image

I have made a styled alert when any one of the input empty it will give a alert when user wants to createtable.

image

I have also added dark mode to it . We can change the color let me know if its okay or not.

I have created a pull request kindly accept the changes.

Siddheshjondhale added a commit to Siddheshjondhale/graphToTable that referenced this issue Oct 15, 2022
…able LunarMarathon#33

Fixed the issue of Two input field should not be empty while generating table LunarMarathon#33
 kindly merge it. I have attached the output in the issue discussion comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants