fix(installer): usernames can contain @ symbol #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you guys know about any other gotchas that I might be missing here? 😅 cc: @chase, @abzcoding |
😂 Fun edge cases. Technically, usernames should not include systemd actually documents it pretty well: https://systemd.io/USER_NAMES/ I don't think # should be a problem since that's a commonly used character for comments. |
chase
approved these changes
Jan 12, 2022
|
It's on macOS, which I never pegged for allowing this but maybe it's some old BSD rule that survived 🤷 |
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Jan 27, 2022
* upstream/master: (57 commits) chore: update changelog chore(installer): require neovim 0.6.1+ (LunarVim#2211) chore(plugins): bump plugin version, also fix for offset_encoding (LunarVim#2210) fix(logging): disable insane amount of logging inside lvim.log (LunarVim#2205) fix(autopairs): remove weird tex rules from autopairs (LunarVim#2206) chore(plugins): bump plugin version (LunarVim#2201) chore(plugins): restore the base folke/lua-dev (LunarVim#2193) chore(plugins): bump plugin version (LunarVim#2190) refactor: remove unused outdated files (LunarVim#2184) fix(lsp): use temporary fork of lua-dev (LunarVim#2187) chore(plugins): bump plugin version and also fix nvim-cmp cmdline issue (LunarVim#2183) refactor(nvim-tree): cleanup and update settings (LunarVim#2182) chore(plugins): bump version (LunarVim#2181) fix(diag): show lsp-diag code in open_float (LunarVim#2180) feat(plugins): bump core plugin version (LunarVim#2176) chore: update changelog fix(which-key): the PR has been merged to the original repo (LunarVim#2172) fix(zsh): don't set filetype to sh (LunarVim#2035) feat(plugins): bump core plugin version (LunarVim#2169) fix(installer): usernames can contain @ symbol (LunarVim#2167) ...
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Jan 27, 2022
* upstream/rolling: (42 commits) chore(plugins): bump plugin version (LunarVim#2217) fix(lsp): avoid accessing undefined user_data (LunarVim#2216) chore(installer): require neovim 0.6.1+ (LunarVim#2211) chore(plugins): bump plugin version, also fix for offset_encoding (LunarVim#2210) fix(logging): disable insane amount of logging inside lvim.log (LunarVim#2205) fix(autopairs): remove weird tex rules from autopairs (LunarVim#2206) chore(plugins): bump plugin version (LunarVim#2201) chore(plugins): restore the base folke/lua-dev (LunarVim#2193) chore(plugins): bump plugin version (LunarVim#2190) refactor: remove unused outdated files (LunarVim#2184) fix(lsp): use temporary fork of lua-dev (LunarVim#2187) chore(plugins): bump plugin version and also fix nvim-cmp cmdline issue (LunarVim#2183) refactor(nvim-tree): cleanup and update settings (LunarVim#2182) chore(plugins): bump version (LunarVim#2181) fix(diag): show lsp-diag code in open_float (LunarVim#2180) feat(plugins): bump core plugin version (LunarVim#2176) fix(which-key): the PR has been merged to the original repo (LunarVim#2172) fix(zsh): don't set filetype to sh (LunarVim#2035) feat(plugins): bump core plugin version (LunarVim#2169) fix(installer): usernames can contain @ symbol (LunarVim#2167) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch the delimiter used in
sedsince usernames can contain@symbolFixes #2162
How Has This Been Tested?