Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable nlsp-settings schemas #2322

Merged
merged 1 commit into from Mar 4, 2022
Merged

feat: enable nlsp-settings schemas #2322

merged 1 commit into from Mar 4, 2022

Conversation

youdaniel
Copy link
Contributor

Description

Allows for nicer autocompletion for :NlspConfig by default.

How Has This Been Tested?

:NlspConfig <language server>

@abzcoding
Copy link
Member

this should already be working?
Screen Shot 2022-03-04 at 3 26 19 PM

because we have this

local full_schemas = vim.tbl_deep_extend(
"force",
require("schemastore").json.schemas(),
require("nlspsettings.jsonls").get_default_schemas()
)
local opts = {
settings = {
json = {
schemas = full_schemas,
},
},
setup = {
commands = {
Format = {
function()
vim.lsp.buf.range_formatting({}, { 0, 0 }, { vim.fn.line "$", 0 })
end,
},
},
},

cc: @kylo252

@kylo252
Copy link
Collaborator

kylo252 commented Mar 4, 2022

I'm not quite sure that I understand the implementation, because it feels like it should have be on by default. However, it seems that the autocomplete inside ~/.config/lvim/lsp-settings/pyright.json is now broken without enabling this flag.

@abzcoding, can you please verify that part?

@abzcoding
Copy link
Member

w8 you are right, maybe it is the new update from them
@youdaniel thank you

@abzcoding abzcoding merged commit 36ffc33 into LunarVim:rolling Mar 4, 2022
@youdaniel youdaniel deleted the enable-nlsp-schemas branch March 4, 2022 20:29
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Mar 7, 2022
* upstream/rolling: (31 commits)
  docs(readme): fix typo in example config (LunarVim#2333)
  chore(plugins): bump version (LunarVim#2327)
  feat: enable nlsp-settings schemas (LunarVim#2322)
  feat: add option to automatically answer 'yes' for sh install script (LunarVim#2306)
  chore(plugins): bump version (LunarVim#2321)
  chore(plugins): bump version (LunarVim#2315)
  refactor(nvim-tree): update settings structure (LunarVim#2304)
  chore: fix typos (LunarVim#2292)
  chore(plugins): bump version (LunarVim#2293)
  fix(timeoutlen): this has caused way too many issues in the past (LunarVim#2287)
  chore(plugins): bump version and fix packer (LunarVim#2284)
  feat(installer): use pnpm to install nodejs dependencies(LunarVim#2279) (LunarVim#2280)
  chore(plugins): bump version (LunarVim#2277)
  fix: correct a path to bufferline module (LunarVim#2270)
  fix: add tsx to treesitter ensure_installed list (LunarVim#2268)
  chore(plugins): bump version (LunarVim#2269)
  feat: add a minimal implementation of bbye (LunarVim#2267)
  refactor(nvim-tree): remove unused code (LunarVim#2266)
  chore(plugins): bump version (LunarVim#2261)
  feat: use bufferline instead of barbar (LunarVim#2254)
  ...
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Mar 19, 2022
* upstream/master:
  chore(release): update changelog
  fix: disable the default intro message (LunarVim#2340)
  feat(windows): add custom config_win.example.lua (LunarVim#2330)
  fix(nlsp-settings): cross platform issue (LunarVim#2335)
  docs(readme): fix typo in example config (LunarVim#2333)
  chore(plugins): bump version (LunarVim#2327)
  feat: enable nlsp-settings schemas (LunarVim#2322)
  feat: add option to automatically answer 'yes' for sh install script (LunarVim#2306)
  chore(plugins): bump version (LunarVim#2321)
  chore(plugins): bump version (LunarVim#2315)
  refactor(nvim-tree): update settings structure (LunarVim#2304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants