fix(peek): make sure popup_options are positive

[abzcoding]

Description

@otto-gebb can you verify if this fixes your issue or not?

Fixes #2369

[kylo252]

LGTM! 🚀

this entire function might have to be removed/refactored If #2369 is still broken, since it's relying on internal functions that aren't guaranteed to not change.

[otto-gebb]

@abzcoding I edited the file
~/.local/share/lunarvim/lvim/lua/lvim/lsp/peek.lua, manually making the changes of this PR.

When I'm trying to "peek definition" of a symbol from a library I get the same error, except the line number in the call steck is now 44 (which means the code lines I added took effect).

Error executing vim.schedule lua callback: /home/gebb/.local/share/lunarvim/lvim/lua/lvim/lsp/peek.lua:44: 'width' key must be a positive Integer
stack traceback:
[C]: in function 'nvim_open_win'
/home/gebb/.local/share/lunarvim/lvim/lua/lvim/lsp/peek.lua:44: in function 'create_floating_file'
/home/gebb/.local/share/lunarvim/lvim/lua/lvim/lsp/peek.lua:73: in function 'handler'
/usr/share/nvim/runtime/lua/vim/lsp.lua:964: in function 'cb'
vim.lua:285: in function vim.lua:285

So I would say no, the changes don't fix the bug.

[abzcoding]

@kylo252 I think instead of if_nil, we should've used the math.max

---

@otto-gebb can you test this instead?

opts = vim.lsp.util.make_floating_popup_options(math.max(width, 30), math.max(height,10) , opts)

[otto-gebb]

@abzcoding with the latest proposed change (math.max) I get a different error:

Error executing vim.schedule lua callback: /home/gebb/.local/share/lunarvim/lvim/lua/lvim/lsp/peek.lua:46: Cursor position outside buffer
stack traceback:
[C]: in function 'nvim_win_set_cursor'
/home/gebb/.local/share/lunarvim/lvim/lua/lvim/lsp/peek.lua:46: in function 'create_floating_file'
/home/gebb/.local/share/lunarvim/lvim/lua/lvim/lsp/peek.lua:72: in function 'handler'
/usr/share/nvim/runtime/lua/vim/lsp.lua:964: in function 'cb'
vim.lua:285: in function vim.lua:285

[abzcoding]

@otto-gebb

can you add this after the opts line you added up there?
and get a screenshot or sth

print(vim.inspect(range))
opts = vim.lsp.util.make_floating_popup_options(math.max(width, 30), math.max(height, 10), opts)

[otto-gebb]

@abzcoding sure. Had to execute :messages to show the print-ed value.

[abzcoding]

@otto-gebb sorry to bother you again, but could you add this one as well and get a screenshot

print(vim.inspect(contents)) -- this is the new one
print(vim.inspect(range))
opts = vim.lsp.util.make_floating_popup_options(math.max(width, 30), math.max(height, 10), opts)

[otto-gebb]

@abzcoding here you go:

BTW, using the debug output technique you showed I printed the values of width and height, which are both 0.

[abzcoding]

yeah it seems like nvim_buf_get_line couldn't access the proper buffer content
while at it, can you do a

print(vim.inspect(location))
print(bufnr)

on top of them

[otto-gebb]

Sure.

It looks to me that the LSP cannot find the definition requested, so maybe the correct behavior of LunarVim should be to print an error instead of rendering a popup.

[abzcoding]

Yeah, I agree. We should print an error if LSP cannot find the proper content. Thank you for helping through the debugging process