Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update demo images on the main readme #2386

Merged
merged 3 commits into from Mar 24, 2022

Conversation

kylo252
Copy link
Collaborator

@kylo252 kylo252 commented Mar 24, 2022

  • updated the demo image to show alpha.nvim
  • added a demo of LvimInfo
  • updated the LSP section
  • removed redundant documentation section (it's already available at the references section)

@abzcoding
Copy link
Member

instead of uploading the images inside the repo, can we use the github upload image link to reduce the repo size?
or is that unnecessary, for example this is my own repo

141789968-ed61958c-9154-4774-b2e2-dfabe48d9660

@kylo252
Copy link
Collaborator Author

kylo252 commented Mar 24, 2022

instead of uploading the images inside the repo, can we use the github upload image link to reduce the repo size? or is that unnecessary, for example this is my own repo

I guess the only downside is not being able to view them offline, but I don't think we're quite there yet in supporting that kind of setup 😄

@abzcoding
Copy link
Member

fantastic, just one thing, i think you forgot the image with startify dashboard

@kylo252
Copy link
Collaborator Author

kylo252 commented Mar 24, 2022

fantastic, just one thing, i think you forgot the image with startify dashboard

I had decided to add it to that media folder but not the main page, since I got worried it's too many images. maybe there's a markdown trick to create clickable thumbnails.
also, feel free to set replacements for other 2 images (maybe something with lsp actions and/or diagnostics)

@abzcoding
Copy link
Member

Yeah, good point. I'll add some fancier images later on. For now, this makes do :)

@abzcoding abzcoding merged commit 1ea836e into LunarVim:rolling Mar 24, 2022
@cizordj
Copy link

cizordj commented Mar 28, 2022

Hi @kylo252, can you please explain how setup an image preview like that?
demo2

In a fresh lunarVim install it doesn't work like that, it only shows me: Binary cannot be previewed.

@abzcoding
Copy link
Member

@cizordj
Copy link

cizordj commented Mar 28, 2022

@abzcoding Thanks

@abzcoding
Copy link
Member

abzcoding commented Mar 28, 2022

@abzcoding Thanks

something like this ->

lvim.plugins = {
  {
    "nvim-telescope/telescope-media-files.nvim",
    requires = "nvim-telescope/telescope.nvim",
  } 
}
lvim.builtin.telescope.extensions.media_files = {
      -- filetypes whitelist
      -- defaults to {"png", "jpg", "mp4", "webm", "pdf"}
      filetypes = {"png", "webp", "jpg", "jpeg"},
      find_cmd = "rg" -- find command (defaults to `fd`)
}
lvim.builtin.telescope.on_config_done = function(telescope)
    telescope.load_extension "media_files"
end

also you might need these
Screen Shot 2022-03-28 at 9 32 59 PM

@cizordj
Copy link

cizordj commented Mar 28, 2022

Thanks for sharing your config file, it'll be extremely helpful for my setup and probably for others as well.

@kylo252 kylo252 deleted the update-readme branch April 17, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants