fix(installer): latest and specified release version for neovim have different urls #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmckiwo
force-pushed
the
neovim-install-fix
branch
from
b84f75b
to
05c1574
Compare
kylo252
changed the title
|
Thank you for your contribution! some minor fixes are needed to pass the CI tests
git commit --amend --no-edit --message "fix(installer): set correct url for nightly"
git push --force -uCheck the contributing guidelines in https://github.com/LunarVim/LunarVim/blob/rolling/CONTRIBUTING.md. |
lmckiwo
force-pushed
the
neovim-install-fix
branch
from
05c1574
to
55acce3
Compare
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
May 1, 2022
* upstream/rolling: feat: add cmp-tmux to the list of sources (LunarVim#2542) feat: gitsigns yadm support (LunarVim#2535) fix(installer): latest and specified release version for neovim have different urls (LunarVim#2484) fix(lsp): undo stdpath overload to avoid datarace (LunarVim#2540) feat(lua-dev): use the newer lua-dev branch till folke comes back (LunarVim#2538) fix(nvimtree): add latest changes from nvimtree (LunarVim#2537) feat(icons): make it possible to disable icons (LunarVim#2529) refactor(lsp): decouple the installer setup-hook (LunarVim#2536)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the URL used to download neovim are different if a version is specified vs if we leave it to default to the latest build.
Fixes #(issue)
How Has This Been Tested?
This script has been tested as follows:
RELEASE_VER=v0.6.1 bash /scripts/install-neovim-from-release
bash /scripts/install-neovim-from-release
and the nvim version verified after the installation.