Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "black" from linting section in README.md #2510

Merged
merged 1 commit into from Apr 23, 2022
Merged

Remove "black" from linting section in README.md #2510

merged 1 commit into from Apr 23, 2022

Conversation

loops
Copy link
Contributor

@loops loops commented Apr 23, 2022

The "black" utility does not include linting functionality. So
including it in that section of the example configuration file,
leads to an error message on startup.

@abzcoding
Copy link
Member

Thank you for your contribution! some minor fixes are needed to pass the CI tests

  1. commit-lint: "subject may not be empty [subject-empty]"
git commit --amend --no-edit --message "fix(readme): remove black as linter"
git push --force -u

Check the contributing guidelines in https://github.com/LunarVim/LunarVim/blob/rolling/CONTRIBUTING.md.

Copy link
Member

@abzcoding abzcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm <3

@abzcoding abzcoding merged commit f49f687 into LunarVim:rolling Apr 23, 2022
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Apr 27, 2022
* upstream/rolling: (48 commits)
  refactor: lock new installations to nvim v0.7+ (LunarVim#2526)
  fix(readme): remove black as linter (LunarVim#2510)
  fix(nvimtree): make sure on_config_done is using the correct require (LunarVim#2509)
  feat(installer): ensure correct responses when prompting user (LunarVim#2506)
  feat(peek): make sure max width and height are customizable (LunarVim#2492)
  chore: bump plugins version (LunarVim#2459)
  fix(nvimtree): escape the dot character in custom filter (LunarVim#2493)
  refactor: update impatient (LunarVim#2477)
  feat: lock nvim <0.7 to a specific tag (LunarVim#2491)
  fix(luasnip): only use user snippets if the folder exists (LunarVim#2481)
  fix(lualine): color theme gaps in some components (LunarVim#2465)
  fix(cmp): bring back default keybindings (LunarVim#2470)
  fix(cmp): update nvim-cmp to the latest version (LunarVim#2467)
  fix(readme): update lsp server ignore syntax
  refactor(lsp): cleanup servers' override configuration (LunarVim#2243)
  feat(cmp): documentation is deprecated in favor of window.documentation (LunarVim#2461)
  docs(windows): use alpha in config_win.example.lua (LunarVim#2452)
  chore: bump plugins version (LunarVim#2448)
  fix(impatient): avoid get_options in fast handler (LunarVim#2451)
  fix(luasnip): make sure all snippets are loaded (LunarVim#2447)
  ...
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Apr 27, 2022
* upstream/master: (63 commits)
  chore: update changelog
  refactor: lock new installations to nvim v0.7+ (LunarVim#2526)
  fix(readme): remove black as linter (LunarVim#2510)
  fix(nvimtree): make sure on_config_done is using the correct require (LunarVim#2509)
  feat(installer): ensure correct responses when prompting user (LunarVim#2506)
  feat(peek): make sure max width and height are customizable (LunarVim#2492)
  chore: bump plugins version (LunarVim#2459)
  fix(nvimtree): escape the dot character in custom filter (LunarVim#2493)
  chore: update changelog
  refactor: update impatient (LunarVim#2477)
  feat: lock nvim <0.7 to a specific tag (LunarVim#2491)
  fix(luasnip): only use user snippets if the folder exists (LunarVim#2481)
  fix(lualine): color theme gaps in some components (LunarVim#2465)
  fix(cmp): update nvim-cmp to the latest version (LunarVim#2467) (LunarVim#2469)
  fix(cmp): bring back default keybindings (LunarVim#2470)
  fix(cmp): hotfix nvim-cmp version
  fix(cmp): update nvim-cmp to the latest version (LunarVim#2467)
  chore: update changelog
  fix(readme): update lsp server ignore syntax
  refactor(lsp): cleanup servers' override configuration (LunarVim#2243)
  ...
PasiBergman pushed a commit to PasiBergman/LunarVim that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants