fix(comment): add extended mappings #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bncpr
changed the title
bncpr
force-pushed
the
core/comment/fix_defualt_mappings
branch
from
e05bc1f
to
c362cc6
Compare
Comment default config was set with extra = false with a comment suggesting this was for `g>`, `g<`, etc. mappings. However the `extra` argument is for the `gco`, `gcO`, and `gcA` mappings which are enabled by default and, in my opinion are very useful. The extended mappings are still disabled by default.
kylo252
force-pushed
the
core/comment/fix_defualt_mappings
branch
from
c362cc6
to
8d73815
Compare
kylo252
changed the title
kylo252
approved these changes
Jul 3, 2022
abzcoding
approved these changes
Jul 3, 2022
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Aug 21, 2022
* upstream/master: (21 commits) chore: update changelog fix(installer) comment causes antivirus false positives (LunarVim#2818) fix(nvimtree): remove `indent_markers` icons trailing space (LunarVim#2854) fix: use pcall for setting up project.nvim (LunarVim#2762) fix(lvim/lsp/manager): make client_is_configured more reliable (LunarVim#2851) perf(cmp): remove redundant check for emmet-ls (LunarVim#2830) chore: update changelog feat(lsp): bind formatexpr and omnifunc by default (LunarVim#2865) chore: bump plugins version (LunarVim#2723) fix(packer): add max_jobs = 40 (LunarVim#2781) Update general-issue-form.yaml refactor(whichkey): use vim.keymap.set directly (LunarVim#2786) fix(core.comment): fix default extra mappings (LunarVim#2768) fix: typo in utils/installer/install.sh (LunarVim#2776) fix(lsp): update format filter for nightly (LunarVim#2773) feat: add commands to open/edit lvim logs (LunarVim#2709) fix dap-install (LunarVim#2772) feat(lsp): add option to override nlsp-settings (LunarVim#2769) feat(lsp): add option to override default `nvim-lsp-installer` settings (LunarVim#2698) fix(installer): always use check shallow clones (LunarVim#2763) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Comment default config was set with extra = false with a comment
suggesting this was for
g>,g<, etc. mappings. However, theextraargument is for the
gco,gcO, andgcAmappings which should be enabledby default and, in my opinion are very useful. The extended mappings are
still disabled by default.
How Has This Been Tested?
Try the mappings.