Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): create profile.ps1 if nonexistent #2810

Merged
merged 2 commits into from Aug 9, 2022

Conversation

vonPB
Copy link
Member

@vonPB vonPB commented Jul 12, 2022

Description

By default PowerShell does not create the file associated with $PROFILE during the installation. MS Docs
The Windows installer script throws an error when trying to add the lvim alias to the user profile.

  • added a check to create the file if nonexistent

fixes #2758 and partly #2805

How Has This Been Tested?

  • Run utils/installer/install.ps1 on fresh vm / without a user profile.ps1

@vonPB vonPB marked this pull request as ready for review July 12, 2022 20:59
@kylo252 kylo252 changed the title fix(installer) create profile.ps1 if nonexistent fix(installer): create profile.ps1 if nonexistent Aug 9, 2022
Copy link
Collaborator

@kylo252 kylo252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the extreme delay, LGTM! 🚀

@kylo252 kylo252 merged commit 7fc0d0f into LunarVim:rolling Aug 9, 2022
@vonPB
Copy link
Member Author

vonPB commented Aug 9, 2022

No worries @kylo252. Thanks for your work!

tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Aug 21, 2022
* upstream/rolling: (30 commits)
  chore: bump plugins version (LunarVim#2895)
  feat(installer): handle INSTALL_PREFIX not on PATH (LunarVim#2912)
  docs: fix automatic_servers_installation example (LunarVim#2918)
  docs: fix some typos and enhance readability (LunarVim#2917)
  fix(statusline): display null-ls linters properly (LunarVim#2921)
  docs(windows): update example config (LunarVim#2919)
  refactor(keymaps)!: don't hijack H/L by default (LunarVim#2874)
  chore: bump plugins version (LunarVim#2893)
  fix(lsp): return the actual resolved mason-config (LunarVim#2889)
  docs(windows): update example config for nvim-tree (LunarVim#2766)
  fix(installer): create profile.ps1 if nonexistent (LunarVim#2810)
  fix(lualine): set icon color according to the status of treesitter (LunarVim#2754)
  feat(lvim/lsp): enable tailwindcss by default (LunarVim#2870)
  fix: handle deprecated telescope.builtin.internal (LunarVim#2885)
  refactor!: migrate to mason.nvim (LunarVim#2880)
  feat(whichkey): add default keybindings to cycle to next buffer (LunarVim#2873)
  fix(installer) comment causes antivirus false positives (LunarVim#2818)
  fix(nvimtree): remove `indent_markers` icons trailing space (LunarVim#2854)
  fix: use pcall for setting up project.nvim (LunarVim#2762)
  fix(lvim/lsp/manager): make client_is_configured more reliable (LunarVim#2851)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to install during alias in windows 10
2 participants