feat: move icons to a single icons file #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylo252
reviewed
Oct 2, 2022
|
Thank you for the review @kylo252, I have applied all of the changes requested. |
prichrd
requested review from
kylo252
and removed request for
ChristianChiarulli
|
could you fix merge conflict, then I'll test and get this merged |
|
It is ready when you are @ChristianChiarulli ! |
|
@prichrd looks like a small formatting issue |
|
@ChristianChiarulli sorry about that, should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Centralize the icons to a
icons.luafile underlua/lvim/.The icons were found using the following grep command:
grep -P -n "[^\x00-\x7F]" -r ./luafixes #3092
How Has This Been Tested?