Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable global installation #3161

Merged
merged 7 commits into from
Oct 7, 2022
Merged

Conversation

kylo252
Copy link
Collaborator

@kylo252 kylo252 commented Oct 6, 2022

Description

  • feat: enable global installation by ensuring that $LUNARVIM_BASE_DIR is independent of $LUNARVIM_RUNTIME_DIR thus allowing system-wide installations
  • feat: automatically create missing user-config
  • fix(git): refuse updating without write-access

Related: #1791, #1021, #1511, #832, #2944

How Has This Been Tested?

  • update your lvim shim and make sure that lvim still starts correctly
    # ...
    export LUNARVIM_BASE_DIR="${LUNARVIM_BASE_DIR:-"$LUNARVIM_RUNTIME_DIR/lvim"}"
    
    exec -a lvim nvim -u "$LUNARVIM_BASE_DIR/init.lua" "$@"
  • remove your config.lua and re-open lvim

ensure that `$LUNARVIM_BASE_DIR` is independent of `$LUNARVIM_RUNTIME_DIR`,
thus allowing system-wide installations
@kylo252 kylo252 mentioned this pull request Oct 6, 2022
@kylo252 kylo252 marked this pull request as ready for review October 6, 2022 10:58
@abzcoding
Copy link
Member

it shows this weird error, but it works nevertheless
Screenshot 2022-10-06 at 4 51 38 PM

@kylo252
Copy link
Collaborator Author

kylo252 commented Oct 7, 2022

it shows this weird error, but it works nevertheless Screenshot 2022-10-06 at 4 51 38 PM

@abzcoding, make sure to switch the shebang at the top, see bc4212b

@kylo252 kylo252 deleted the global-install branch October 7, 2022 12:34
@abzcoding
Copy link
Member

it shows this weird error, but it works nevertheless Screenshot 2022-10-06 at 4 51 38 PM

@abzcoding, make sure to switch the shebang at the top, see bc4212b

yep fixed, thanks 👍

@kylo252 kylo252 mentioned this pull request Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants