New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(telescope): add lvim.builtin.telescope.theme
#3548
feat(telescope): add lvim.builtin.telescope.theme
#3548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- normal mode is just adding more steps so we should remove it
- the global theme should be more easily configurable, here's an example of how to do that: https://github.com/kylo252/lvim/blob/d381278cf22fdf6f7a7cc59da10aeced315f082f/lua/user/telescope.lua#L60-L31
I'm okay with splitting the theme refactor to another PR if you don't feel like dealing with it tho :)
the suggested changes would change the theme to horizontal in the affected pickers and enable the preview in some, is that change intentional?
I'd be happy to do it, not sure what to do though |
correct, it's more of a way for me to keep track of which theme is being used 😅 that code block is basically my way of inlining this functions: https://github.com/nvim-telescope/telescope.nvim/blob/cea9c75c19d172d2c6f089f21656019734a615cf/lua/telescope/themes.lua#L98-L135
The theme should be controlled globally to make it more consistent. As for the preview, we should definitely drop them from this table since we don't want those changes to be global. We can preserve the current behavior, where desired, in the mapping itself f = { "<cmd>Telescope find_files previewer=false theme=dropdown<cr>", "Find File" },
let's figure it out together :) related #2286 cc: @abzcoding |
I've added |
and how about doing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and how about doing Various themes for the main UIs as a separate plugin that you require in your config and it applies some settings?
introducing a new theme should be done as a plugin, which is the idea in #2286 (comment) since it requires extra fiddling with highlight groups, see https://github.com/abzcoding/lvim/blob/575310300e72a5ff14c424e21aabe7e43baefa9e/lua/user/theme.lua#L437-L497, but I don't think we need a plugin just for selecting the theme.
Co-authored-by: kylo252 <59826753+kylo252@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
lvim.builtin.telescope
completionlvim.builtin.telescope.theme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
* upstream/master: feat(telescope): add `lvim.builtin.telescope.theme` (LunarVim#3548)
Description
lvim.builtin.telescope.pickers
will now be autocompletedpartially fixes #3406
How Has This Been Tested?