Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: startify theme button bugfix #3557

Merged
merged 2 commits into from Dec 1, 2022
Merged

fix: startify theme button bugfix #3557

merged 2 commits into from Dec 1, 2022

Conversation

Gowa2017
Copy link
Contributor

startify theme button bugfix

@LostNeophyte
Copy link
Member

Thanks for the pr :)
I've changed lvim.builtin.alpha[theme_name].section.buttons.opts to a functon argument, because there also exist top_buttons and top_buttons, I forgot about that earlier

LostNeophyte
LostNeophyte previously approved these changes Nov 30, 2022
View reviewed changes
@kylo252 kylo252 merged commit 02de1b1 into LunarVim:master Dec 1, 2022
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Dec 8, 2022
Merge remote-tracking branch 'upstream/master'
7ee3e64 
* upstream/master:
  fix(terminal): use user's shell in execs (LunarVim#3531)
  ci: better issue templates description (LunarVim#3571)
  feat: support 'hrsh7th/cmp-cmdline' by default (LunarVim#3545)
  feat(wich-key): binding to save without formatting (LunarVim#3165)
  fix: startify theme button bugfix (LunarVim#3557)
  fix(dashboard): remove feedkeys (LunarVim#3558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylo252 kylo252 kylo252 approved these changes

@LostNeophyte LostNeophyte LostNeophyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gowa2017 @LostNeophyte @kylo252