Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: disable strange autopairs rules #3759

Merged
merged 1 commit into from Jan 23, 2023

Conversation

meijieru
Copy link
Contributor

Existing autopairs rules should be opt-in instead of as a default.

@LostNeophyte
Copy link
Member

these were actually quite annoying for me personally

as for the todo in the code: yes, you can add rules from config.lua

lvim.builtin.autopairs.on_config_done = function()
  local npairs = require("nvim-autopairs")
  local Rule = require("nvim-autopairs.rule")
  npairs.add_rules({
    Rule("<", ">"),
  })
end

Copy link
Member

@LostNeophyte LostNeophyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LostNeophyte
Copy link
Member

the rules were added in #315 which makes no sense to me

@LostNeophyte LostNeophyte merged commit 8ea6883 into LunarVim:master Jan 23, 2023
@LostNeophyte
Copy link
Member

Thanks!

tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Jan 24, 2023
* upstream/master:
  refactor!: remove `%` and `$` autopairs rules (LunarVim#3759)
  chore: bump plugins version (LunarVim#3761)
  feat: add crystal filetype (LunarVim#3762)
  fix(lsp): info diagnostic icon not showing (LunarVim#3756)
  fix(logger): fix errors with older structlog versions (LunarVim#3755)
  chore: bump plugins version (LunarVim#3679)
  refactor(logger): adapt to new changes upstream (LunarVim#3695)
@meijieru meijieru deleted the remove_autopairs_rules branch March 12, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants