Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace deprecated MDI Orbit icon #3880

Merged
merged 1 commit into from Feb 25, 2023
Merged

chore: replace deprecated MDI Orbit icon #3880

merged 1 commit into from Feb 25, 2023

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Feb 21, 2023

Description

Replaces the old Material Design nf-mdi-orbit icon with the new one nf-md-orbit.

The old one is deprecated since Nerd Fonts v2.3, and will be removed in v3.

How Has This Been Tested?

  1. Edit lua/lvim/core/lualine/components.lua
  2. Check the statusline:
    Screenshot 2023-02-21 at 10 58 42

Additional context

Replaces the old Material Design nf-mdi-orbit icon with the new one
nf-md-orbit.

ryanoasis/nerd-fonts#1097
Copy link
Member

@LostNeophyte LostNeophyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@ChristianChiarulli do we merge it now or wait? the change is quite recent and the majority of users probably didn't update the font yet

@antoineco
Copy link
Contributor Author

I have two conflicting opinions regarding this:

  • master branch is bleeding edge, so this is fine and probably a good way to get people to update their fallback font. Sooner or later they will run into this issue.
  • The glyphs won't actually be removed until Nerd Fonts v3, so let's align on that release.

Copy link
Collaborator

@kylo252 kylo252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@kylo252 kylo252 merged commit 5951c43 into LunarVim:master Feb 25, 2023
@antoineco antoineco deleted the replace-deprecated-orbit-icon branch February 25, 2023 11:35
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Feb 27, 2023
* upstream/master:
  fix(config-loader): defer invalid configuration warning (LunarVim#3869)
  chore: replace deprecated MDI Orbit icon (LunarVim#3880)
  fix: lazy cache (LunarVim#3892)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants