fix(lsp): incorrect g goto capitalization
#3950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- gd: go definition - gD: go Declaration
cpea2506
approved these changes
Mar 13, 2023
rebuilt
approved these changes
Mar 20, 2023
|
Thanks! Good catch 😁 |
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Mar 20, 2023
* upstream/master: fix(dap): invalid border value (LunarVim#3951) fix: copilot indent reset (LunarVim#3343) (LunarVim#3960) fix(lsp): incorrect `g` goto capitalization (LunarVim#3950)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects the capitalization of the g goto shortcut in the keybindings, which was previously inconsistent with the corresponding actions. Specifically, gd (go to definition) should be lowercase, while gD (go to Declaration) should be uppercase. This update ensures that the keybindings are more intuitive and consistent with their associated actions.
How Has This Been Tested?
gshows the goto dashboard, the capitalized D should be mapped to Declaration instead of definition.