Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just a minimal Go template to get things underway #6

Merged
merged 2 commits into from
Dec 26, 2021

Conversation

BBoal
Copy link

@BBoal BBoal commented Dec 26, 2021

Hi there! Love your idea and your plugin. I've been using it for the past week, and thought about giving a "nanoscopic" contribution. Thanks for sharing! Merry Christmas!

@LunarWatcher LunarWatcher mentioned this pull request Dec 26, 2021
8 tasks
@LunarWatcher LunarWatcher changed the base branch from template-patches to master December 26, 2021 15:05
@LunarWatcher
Copy link
Owner

LunarWatcher commented Dec 26, 2021

LGTM; why do you redraw! though? That clears the output.

Though I guess the alternative here might be to echom instead of echo, but that's something I can fix in the master branch instead of handling it here if there's a good reason to redraw.

And thanks for fixing the string concatenation, I overlooked those here when I realized .. is valid and fairly compatible

@LunarWatcher
Copy link
Owner

Aight, gonna merge then.

Thanks for your contribution!

@LunarWatcher LunarWatcher merged commit 5957037 into LunarWatcher:master Dec 26, 2021
@BBoal
Copy link
Author

BBoal commented Dec 26, 2021

Sorry for the late reply...
Had to try the plugin in Neovim to understand what you meant. In terminal Vim, there are a bunch of cases that chop the screen after using silent! forcing the usage of redraw! afterwards. I was experiencing another of these cases, and applied the known solution (I wasn't seeing your echo messages in the output either way).
After trying your alternative, the outcome is much better. I've ditched the redraw! and changed the echo to echom. In Neovim, everything goes smooth and in Vim, the messages are available using :messages.
Do you mind if I make another PR with these changes?
Best regards,

@LunarWatcher
Copy link
Owner

... of course terminal vim works differently. I've only really tested in gVim, and I regularly forget how many benefits there are over the terminal variant ^^"

As for your suggested second PR, I'm not sure I've understood what you want to include -- seems to me like you did this in 9e114f1 already, unless I'm misunderstanding?

@BBoal
Copy link
Author

BBoal commented Dec 26, 2021

Everything is done. I was just writing my previous message to you when I got interrupted and in the meanwhile you merged. Being a father is hard and challenging, but during Covid times is colossal... Rant aside, I found you through the autopairs plugin, which is awesome, and wanted to thank you for your time and for sharing your ideas. I hope to use more of your future plugins in my future vimrc 😄 . Happy coding!

@LunarWatcher
Copy link
Owner

Understandable, it's been a long and hard couple years. I hope we get to return to normal some time soon, but I'm also not super optimistic. No worries either, as long as we get it sorted, I'm not complaining. I get people have lives, and that async communication necessarily results in unexpected interruptions like the one here.

Anyway, happy coding and merry christmas (or a happy new year by now I guess? :p) to you too!

@BBoal
Copy link
Author

BBoal commented Dec 31, 2021

You're way too fast... Both in async communication and in wishing Happy New Year :p
Now is the time... Happy New Year to you Olivia, wish you the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants