Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Slow? #4

Closed
cwilliams5 opened this issue Feb 4, 2022 · 3 comments · Fixed by #6
Closed

Super Slow? #4

cwilliams5 opened this issue Feb 4, 2022 · 3 comments · Fixed by #6
Assignees
Labels
bug Something isn't working

Comments

@cwilliams5
Copy link
Contributor

Describe the bug
Look's like something is wrong with speed.

To Reproduce
Steps to reproduce the behavior:

  1. Run the program.
  2. Items/Sec is very high.
  3. Log is showing a bunch of odd repeats.

Expected behavior
Be able to add 50 licenses per hour as the Steam API allows. Perhaps even faster if ASF lets us know the product is already owned.

Screenshots
image

Desktop (please complete the following information):

  • Windows 10

Additional context
In the log I can see items repeating over and over. Even without repeating it would be slow, but this is slowing it way further.

Also ASF !addlicense accepts a comma seperated list, wouldn't that be faster to do 50 at a time that way? Although maybe you don't get back enough in the response to know what to log/retry, I don't know.

Logging data:
`12:47:14,989 urbanGUI DEBUG Found config file
12:47:14,989 asyncio DEBUG Using proactor: IocpProactor
12:47:15,550 urllib3.connectionpool DEBUG Starting new HTTPS connection (1): raw.githubusercontent.com:443
12:47:15,892 urllib3.connectionpool DEBUG https://raw.githubusercontent.com:443 "GET /Luois45/claim-free-steam-packages/update-package_list/package_list.txt HTTP/1.1" 200 42184
12:47:15,921 urbanGUI DEBUG
Package found in activated_packages
12:47:15,922 urbanGUI DEBUG
Package not found in activated_packages
12:47:16,106 urbanGUI INFO
ID: app/1446570 | Status: OK | Items: app/1446570

12:48:46,109 urbanGUI DEBUG
Package not found in activated_packages
12:48:46,255 urbanGUI INFO
ID: app/1446670 | Status: OK | Items: app/1446670

12:50:16,269 urbanGUI DEBUG
Package not found in activated_packages
12:50:16,451 urbanGUI INFO
ID: app/1446720 | Status: OK | Items: app/1446720

12:51:46,459 urbanGUI DEBUG
Package not found in activated_packages
12:51:46,656 urbanGUI INFO
ID: app/1446740 | Status: OK | Items: app/1446740

12:53:16,664 urbanGUI DEBUG
Package not found in activated_packages
12:53:16,879 urbanGUI INFO
ID: app/1445970 | Status: OK | Items: app/1445970

12:54:46,889 urbanGUI DEBUG
Package not found in activated_packages
12:54:47,119 urbanGUI INFO
ID: app/1446020 | Status: OK | Items: app/1446020

12:56:17,133 urbanGUI DEBUG
Package not found in activated_packages
12:56:17,315 urbanGUI INFO
ID: app/1446120 | Status: OK

12:57:47,524 urbanGUI INFO
ID: app/1446120 | Status: OK

12:59:17,719 urbanGUI INFO
ID: app/1446120 | Status: OK

13:00:47,920 urbanGUI INFO
ID: app/1446120 | Status: OK

13:02:18,130 urbanGUI INFO
ID: app/1446120 | Status: OK

13:03:48,333 urbanGUI INFO
ID: app/1446120 | Status: OK

13:05:18,537 urbanGUI INFO
ID: app/1446120 | Status: OK

13:06:48,734 urbanGUI INFO
ID: app/1446120 | Status: OK

13:08:18,936 urbanGUI INFO
ID: app/1446120 | Status: OK

13:09:49,145 urbanGUI INFO
ID: app/1446120 | Status: OK

13:12:49,161 urbanGUI DEBUG
Package not found in activated_packages
13:12:49,392 urbanGUI INFO
ID: app/1446230 | Status: OK | Items: app/1446230

13:14:19,402 urbanGUI DEBUG
Package not found in activated_packages
13:14:19,598 urbanGUI INFO
ID: app/1445330 | Status: OK | Items: app/1445330

13:15:49,613 urbanGUI DEBUG
Package not found in activated_packages
13:15:49,800 urbanGUI INFO
ID: app/1445510 | Status: OK | Items: app/1445510

13:17:19,817 urbanGUI DEBUG
Package not found in activated_packages
13:17:20,18 urbanGUI INFO
ID: app/1445610 | Status: OK | Items: app/1445610

13:18:50,25 urbanGUI DEBUG
Package not found in activated_packages
13:18:50,253 urbanGUI INFO
ID: app/1445640 | Status: OK | Items: app/1445640

13:20:20,258 urbanGUI DEBUG
Package not found in activated_packages
13:20:20,457 urbanGUI INFO
ID: app/1445700 | Status: OK | Items: app/1445700

13:21:50,467 urbanGUI DEBUG
Package not found in activated_packages
13:21:50,665 urbanGUI INFO
ID: app/1445710 | Status: OK | Items: app/1445710

13:23:20,679 urbanGUI DEBUG
Package not found in activated_packages
13:23:20,868 urbanGUI INFO
ID: app/1444970 | Status: OK | Items: app/1444970

13:24:50,871 urbanGUI DEBUG
Package not found in activated_packages
13:24:51,61 urbanGUI INFO
ID: app/1445040 | Status: OK | Items: app/1445040

13:26:21,68 urbanGUI DEBUG
Package not found in activated_packages
13:26:21,420 urbanGUI INFO
ID: app/1445170 | Status: OK

13:27:51,634 urbanGUI INFO
ID: app/1445170 | Status: OK

13:29:21,824 urbanGUI INFO
ID: app/1445170 | Status: OK

13:30:52,29 urbanGUI INFO
ID: app/1445170 | Status: OK

13:32:22,288 urbanGUI INFO
ID: app/1445170 | Status: OK

`

@cwilliams5 cwilliams5 added the bug Something isn't working label Feb 4, 2022
@Luois45 Luois45 self-assigned this Feb 4, 2022
@Luois45
Copy link
Owner

Luois45 commented Feb 4, 2022

I've had a look into it, and it seems like it is happening because of a bug in the code which does reduce the possible speed by quite a lot.
I will create a pr fixing the bug later today.

Luois45 added a commit that referenced this issue Feb 4, 2022
@Luois45 Luois45 linked a pull request Feb 4, 2022 that will close this issue
@Luois45 Luois45 closed this as completed in #6 Feb 4, 2022
Luois45 added a commit that referenced this issue Feb 4, 2022
Fixed #4 and improved performance
@cwilliams5
Copy link
Contributor Author

Yep, can confirm I'm getting 90.2s/it now, so its matching the sleep. Ty for fixing. Don't forget to burn a new .exe for those who need it.

Oh and threw an idea in #5 that would also help with speed.

@Luois45
Copy link
Owner

Luois45 commented Feb 4, 2022

Thanks for the reminder.
I will build a new exe file in the next few days.
Had already a look at the idea in #5, but will answer there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants