Improved testing and update readme / docs #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"subTest" used in "test_all_sites" is not available in py2 unittest so we use unittest2 instead.
Nachtalb
force-pushed
the
na/improved-testing
branch
7 times, most recently
from
1c4dfb6
to
187f612
Compare
|
@LuqueDaniel Do you know how to fix the travis / appveyor stuff. One problem is that pylint returns exit code 30 which by both systems count as fail. And then the differences between the OSX and Linux machines on travis. |
Nachtalb
force-pushed
the
na/improved-testing
branch
from
187f612
to
a9a5ed6
Compare
|
@Nachtalb First of all thank you very much for your contribution. A few weeks ago I added pylint as a linter, but I still have to configure it so that it isn't so strict. Sorry for the inconvenience. |
LuqueDaniel
reviewed
Feb 27, 2020
|
AppVeyor and Travis settings fixed. |
LuqueDaniel
reviewed
Feb 27, 2020
|
|
||
|
|
||
| class TestApiClients(TestCase): | ||
| client_mapping = { |
There was a problem hiding this comment.
The #44 changes have been merged. Adds lolibooru too.
|
I didn't know zest.releaser I really like the idea. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically introduces a new way of writing tests. Instead of a single file at the project root, we use pythons
unittestlib (in this caseunittest2because we want the same support for py2.7 and py3.6).Additionally, I fixed a view things with the
setup.pyand the documentation.setup.pyshould not import anything from the project itself because it leads to errors like not being able to usepython setup.py install/developbecause it tries to importrequestswhich it wouldinstallwith either of the said commands.TheJust saw there is asphinxrequirements to build the documentation were nowhere to be found.Pipfile. Thus, I added an extra (docs) which installs the required packages for us.unittests2so we can run the tests.Your intent of importing the version from your package was probably so that you won't forget to update the version string somewhere without noticing. For that, I wholeheartedly recommend
zest.releaserhttps://pypi.org/project/zest.releaser/. This package makes life as a developer easy by removing the whole hassle of releasing stuff.Before you release a package you can run
longtestto check if the readme and changelog markup is correct and then you runfullreleasewhich does the whole release pipeline.