Added 504 error to HTTP_STATUS_CODE in resources.py #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! for contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a line for 504 server timeout errors to resources.py
Motivation and Context
I was getting a KeyError from pybooru exceptions because danbooru was returning a 504, so I added a line to the HTTP_STATUS_CODE dictionary so that it can handle this error correctly.
How Has This Been Tested?
I am currently running the version with this line changed in an app and I also ran the provisional_test.py (of course neither of these test for a 504 response but I'm not sure danbooru provides the capability to test for a 504 response so...)
Types of changes
Checklist: