Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoloader function loadLastResort always returns false #150

Closed
torel opened this issue Jun 13, 2013 · 1 comment
Closed

Autoloader function loadLastResort always returns false #150

torel opened this issue Jun 13, 2013 · 1 comment

Comments

@torel
Copy link

torel commented Jun 13, 2013

First line of function loadLastResort in Autoloader reads "return false;".

Is this a bug or intentionally?
Commenting out first line is not a good option when using automatic builds with composer..

If this is intentionally, I fail to see the reason why it has been included - since __invoke function returns if autoloading succeeds before the point of calling loadLastResort.

nickl- added a commit that referenced this issue Jul 13, 2013
Remove method bypass loadLast resort.

As pointed out by @torel #150 and likely the fix for #72 and I am am sure we removed this before but somehow it came back.
@nickl-
Copy link
Contributor

nickl- commented Jul 13, 2013

@torel thanks for spotting that it is out of sync with what I've had locally for ever.
Good one!

@nickl- nickl- closed this as completed Jul 13, 2013
nickl- added a commit that referenced this issue Jul 13, 2013
Remove method bypass loadLast resort.

As pointed out by @torel #150 and likely the fix for #72 and I am am sure we removed this before but somehow it came back.
nickl- added a commit that referenced this issue Jul 29, 2013
Remove method bypass loadLast resort.

As pointed out by @torel #150 and likely the fix for #72 and I am am sure we removed this before but somehow it came back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants