-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize exporter-toolkit flag parsing #162
Conversation
Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>
Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>
@Lusitaniae do you have any thoughts on this change? |
in node exporter looks like the toolkit can load the flags directly Also seems we can use it to generate the landing page too Maybe need more work here? |
@Lusitaniae I'm not sure what you mean by "load the flags directly" or how the node_exporter code differs to what I've proposed - other than the The landing page functionality in exporter-toolkit is new, and was not available when I opened this PR. Personally, I would recommend keeping that for a separate PR. |
Sounds fair I'll leave it to @blkperl |
This LGTM |
Many thanks Merged and released in https://github.com/Lusitaniae/apache_exporter/releases/tag/v1.0.0 if you'd like to test |
Use modern method of parsing listener address(es) and TLS config file, provided by prometheus/exporter-toolkit.
Refs: #148
Note that this introduces a breaking change.
The following flags:
will change to:
Additionally, the systemd socket flag will be offered (on Linux):