Content Type parsing error

[skol-pro]

I simply tried using the sample code on the readme (replacing urls of course), but I just get the following error:
apiRoot.$request is not a function

Any help would be appreciated. :-/

[maennchen]

Could you console.log the apiRoot?

[skol-pro]

Wow, fast answer, was expecting to wait for hours :-)
Sure, looks like I get the common stuff from $http:

Controller code:

$rootScope.apiRoot = $http({url: 'http://localhost:8080/api-1.0/'});

$rootScope.$watch('apiRoot', function(apiRoot){
    if (apiRoot != undefined) {
        $rootScope.dashboards = apiRoot.$request().$get('foo');
    }
});

Object {}
    catch: function (a)
    error: function (a)
    finally: function (a)
    success: function (a)
    then: function (b,f,h)
    __proto__: Object

[maennchen]

Which version are you on? v2.0.0-alpha.4?

[skol-pro]

I edited my last post with the ctrl code.
And I simply took the angular-hal.min.js from the git repo.

[maennchen]

Ah, I see the error in my README.

Try this:

$http({url: 'http://localhost:8080/api-1.0/'})
  .then(function(apiRoot) {
    $rootScope.apiRoot = apiRoot;
  });

$rootScope.$watch('apiRoot', function(apiRoot){
    if (apiRoot != undefined) {
        $rootScope.dashboards = apiRoot.$request().$get('foo');
    }
});

[skol-pro]

Yeah, I spotted that too, and tried to assign in then, without really real success :(

Still getting:
angular.min.js:93 TypeError: apiRoot.$request is not a function

[maennchen]

What Content-Type does your server send with the answer?

[skol-pro]

Content-Type: application/hal+json;charset=UTF-8
Is there something wrong with it ?

[skol-pro]

Looks like $http has been kept untouched. I mean, I guess angular-hal is extending default $http, right ? :-)

[maennchen]

I think I've implemented this line wrong:
https://github.com/LuvDaSun/angular-hal/blob/master/src/http-interception/resource-http-interceptor.factory.js#L52

[skol-pro]

Well spotted !
Something like this would be better then ?!...

if (response.headers('Content-Type').indexOf(CONTENT_TYPE) > -1) { ... }

EDIT: Doing so make it works on my side at least :p

[maennchen]

I think it would be good to integrate a library like this one:
https://www.npmjs.com/package/content-type

[skol-pro]

Not a bad idea indeed, since it's a pretty lightweight library.

[maennchen]

Would you be interested to make a pull request for that?

[skol-pro]

You mean, to add the library and refactor angular-hal to work with it ?

[maennchen]

Yes, exactly. And maybe also write a test for it.

[skol-pro]

Ok why not, you have to know that it will be my first time contributing, but I'm really glad to ! :-)

[skol-pro]

So, I've created a simple module + factory, but actually I'm just wondering 3 things:

• No node modules folder, could you describe me how you would install the content-type lib ?
• Should I let you create the minified version or is it on contributors shoulders to do this ? If so, how do you proceed ?
• Still not really used to testing. If you do some, I would appreciate, so that I can check what you did !

I quite simply "duplicated" url-generator module & factory to create that, so, no-brain. I wouldn't be surprised if you tell me it's total bull**** :p

As I said, first time contributing, not used to all this stuff, and I'm really happy to be able to learn & contribute :)