Content-type parsing

[skol-pro]

• Created Content-Type module + factory
• Refactored resource-http-interceptor factory to use content-type checker

[maennchen]

Could you add the bower & npm dependency?

[skol-pro]

See my comment on #46

[maennchen]

Ah, sorry.

1. You can install it by adding it to the package.json and bower.json.

npm install content-type --save
bower install --save jshttp/content-type

1. Run those commands at the end:

npm install
npm run compile

1. I'll write the test for you as a gist.

[skol-pro]

Awesome ok, I already ran npm install but I was afraid that it would create useless stuff.
Whatever, will keep that in mind, thank you. I'm just wondering where that "jshttp/" comes from ?

Thank you for the test, will take a look then.

[maennchen]

The jshttp comes from the github username of the author. I'm however afraid, that the package is in fact not compatible with bower.
I'll create a fork which will support it.

[skol-pro]

Ooooh ok I see.
By the way, I'm just discovering npm run compile, this is awesome ! Beginning to understand processes.

[skol-pro]

Ok I added dependencies etc. No need for new pull-request ?

[maennchen]

If you push again, the pull request will get updated.

[skol-pro]

Ok, already pushed, good.
Indeed, I can see it has been updated.

[maennchen]

This is the test I wrote:
https://github.com/LuvDaSun/angular-hal/blob/master/test/content-type.spec.js

I had to improve a few things which you see in the latest commit.

Thank you very much.

[skol-pro]

Cool, all of this makes sense !
I guess you just forgot to return self; at 1f6ec9b#diff-2963df74eb8dde1731c4892061716901L957 :p

[maennchen]

When angular creates a service, it does it using 'new service()' which will create an instance.
The doesn't have to be returned that way. (but does no harm either...)

[maennchen]

BTW: I just made an improvement to the README.

[skol-pro]

Oh really, thought returning self (or this) was necessary.
Perfect regarding the README, nothing can fail anymore !

[maennchen]

function withReturn() { return this;}
function without() {}
withReturn() // withReturn {}
new withReturn() // withReturn {}
without() // undefined
new without() // without {}

[skol-pro]

Ah ah :D Ok ok, not sure I got that but that's ok, will keep in mind too.

[skol-pro]

You should had the content-type dependency in the README too.
Don't know if user can choose to add the content-type.js stuff or has to do a npm install...

[skol-pro]

I mean, for those like who haven't installed angular-hal using npm at least.

[maennchen]

I opened an issue. I'll do it tomorrow.

[skol-pro]

Hehe, have a good-night ;-)