Fix Pointer node #769
Merged
Fix Pointer node #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -163,7 +163,7 @@ def poll(cls, context): | |||
| NodeItem("LuxCoreNodeTexIrregularData", label="Irregular Data"), | |||
| ]), | |||
|
|
|||
| LuxCoreNodeCategoryMaterial("LUXCORE_MATERIAL_SHAPE", "Shape Modifiers", items=[ | |||
| LuxCoreNodeCategoryMaterial("LUXCORE_MATERIAL_SHAPE", "Shape Modifiers", items=[ | |||
There was a problem hiding this comment.
While investigating the issue I noticed the indentation on this line was incorrect. This is not critical to solving the issue, but I thought it would be good to fix it anyway.
|
I'm also confirming issue solved. Thanks. |
|
I'm also confirming this fix resolved the issue. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #770 Pointer node does not allow selecting a material, volume, or texture
The
LUXCORE_MT_pointer_select_node_treemenu is callingpoll_nodefrom its@pollclass method, and it seems to always returnFalsebecause when it is calledcontexthas no attributenode. I don't know why this stopped working, or even if it ever did.Returning
Falsefrompollcauses the Pointer node to not show the drop-down menu at all, making it impossible to use the Pointer node at all.To fix this, we can remove the
pollmethod (same thing as always returningTrue, and instead check that thenodeis present in thedrawmethod, before we try to use it.