Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidirectional CPU failing tests MacOS #156

Closed
rebpdx opened this issue Nov 5, 2018 · 2 comments
Closed

Bidirectional CPU failing tests MacOS #156

rebpdx opened this issue Nov 5, 2018 · 2 comments
Assignees
Labels

Comments

@rebpdx
Copy link
Contributor

rebpdx commented Nov 5, 2018

Bidirectional CPU is failing tests with an out of bounds PDF on MacOS

Steps to reproduce

  1. Compile LuxCore on MacOS
  2. Run Python tests for BIDIRCPU

Observe failed assert for throughput.IsInf()

Version and Hardware info

LuxCore v2.1Alpha4
Mac OS 10.12.6

Root Cause Analysis:

Root cause is yet to be not determined, it appears that the throughput.IsInf() occurs twice for BIDIRCPU_METROPOLIS infinite light test and occasionally passes tests for BIDIRCPU_RANDOM infinite light test.

Floating point arguments for Clang on Mac OS have been investigated and appear to be set to most accurate options possible to avoid rounding and optimization errors.

It was also determine that Linux on the same hardware passes these tests as expected. It has not been determined if Clang in Linux passes these tests which may help isolate Clang vs. GCC or Linux vs. MacOS related issue.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@rebpdx
Copy link
Contributor Author

rebpdx commented Dec 2, 2018

The issue is no longer reproducible since v2.1beta2 root cause is unknown, most likely related to the Embree 3.2.4 update or bad build environment during v2.1alpha4.

With the v2.1beta2 builds it was confirmed that clang in Linux builds and passes tests as well.

@Dade916
Copy link
Member

Dade916 commented Apr 4, 2020

I assume this is now outdated and can be closed.

@Dade916 Dade916 closed this as completed Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants