Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LuxCore fails to build with boost 1.73 due to placeholder namespace change #449

Closed
luyatshimbalanga opened this issue Sep 19, 2020 · 4 comments
Assignees
Labels

Comments

@luyatshimbalanga
Copy link

luyatshimbalanga commented Sep 19, 2020

Due to the switch to c++14 inside openvdb 7.1.0, LuxCore will no longer build.
Unfortunately, I am unable to find a way to swich -std to c++14 so suggestion is needed.
Here is
build.log

@Dade916
Copy link
Member

Dade916 commented Sep 19, 2020

OpenVDB v7.0 is intentionally included inside the repository (https://github.com/LuxCoreRender/LuxCore/tree/master/deps/openvdb-7.0.0/openvdb) to avoid this kind of problems, do you have any particular reason to use OpenVDB v7.1 over v7.0 ?

@Dade916 Dade916 self-assigned this Sep 19, 2020
@luyatshimbalanga
Copy link
Author

The Fedora build system has openvdb-7.1.0. In default setting as seen on the attached build.log, the failure happened on dep/openvdb-7.0.0. Is there a way to adjust that? See the spec file on the cmake section : https://src.fedoraproject.org/rpms/luxcorerender/blob/master/f/luxcorerender.spec

@luyatshimbalanga luyatshimbalanga changed the title LuxCore fails to build with openvdb 7.1.0 LuxCore fails to build with boost 1.73 due to placeholder namespace change Sep 20, 2020
@luyatshimbalanga
Copy link
Author

It turned out the cause of built failure is the change done in boost 1.73 regarding the placeholder namespace.
Additionally, LuxCore successfully built with -std=c++14. Here is the patch including the solution. I edited the title to reflect the finding from the Fedora team.
LuxCore-use-cxx-standard-14.patch.txt

@Dade916
Copy link
Member

Dade916 commented Sep 21, 2020

We have specific build Environment for Linux available here: https://github.com/LuxCoreRender/LinuxCompile

It is pretty much a static build in order to have something that will work on most Linux distributions and all the mess of different library versions available out there.
Using different versions from the one we have tested may introduced unknow bugs (and has in the past) so we can not support it.

Thanks for the patch, I guess it can stay here for future reference and anyone interested.

@Dade916 Dade916 closed this as completed Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants