Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some slg libraries violates the C++ One Definition Rule on 2.8alpha1 #625

Open
luyatshimbalanga opened this issue Dec 30, 2023 · 0 comments

Comments

@luyatshimbalanga
Copy link

The build system from Fedora reported a violation of C++ One Definition Rule within the SLG libraries. See
build.log with the following extract:

builddir/build/BUILD/LuxCore-luxcorerender_v2.8alpha1/redhat-linux-build/generated/luxparser/luxparse.hpp:139:34: warning: ‘luxcore_parserlxs_yylval’ violates the C++ One Definition Rule [-Wodr]
  139 | extern LUXCORE_PARSERLXS_YYSTYPE luxcore_parserlxs_yylval;
      |                                  ^
/builddir/build/BUILD/LuxCore-luxcorerender_v2.8alpha1/redhat-linux-build/generated/luxparser/luxparse.cpp:1728:9: note: type ‘union LUXCORE_PARSERLXS_YYSTYPE’ itself violates the C++ One Definition Rule
 1728 | YYSTYPE yylval;

Affected version: LuxCore 2.8 alpha1

Tested on development branch of Fedora running on GCC 13
root.log with built dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant