feat: first working version for DocumenterCitations #139
Conversation
- fix also the ordered list printing
|
it would be good to have at least a very simple example in https://luxdl.github.io/DocumenterVitepress.jl/dev/code_example or where appropriate. As it is, I cannot see how it would look like. |
|
I added a bit of documentation in thofma#1, but it doesn't seem to be rendering... |
|
This is just the backend (writer), so all I could do is copy verbatim what is written here: https://github.com/JuliaDocs/DocumenterCitations.jl?tab=readme-ov-file#usage |
Add docs and minor code cleanups
|
thanks @asinghvi17 (I also would not mind if you push directly, which you should be able to) |
|
It is still kind of broken: https://github.com/LuxDL/DocumenterVitepress.jl/actions/runs/9146691992/job/25147180913?pr=139#step:6:116 But it seems to work for me locally (for my own repo, not this one here). |
|
Ah I forgot this is an external PR...yeah I saw those locally as well, I'm not sure where they're coming from though. |
|
See the preview for #140, this seems to be working online (but not locally for me somehow). There is an issue with the navbar/sidebar printing though, probably related to the change made here. |
|
you have to ask the author of #117 :) |
|
You can tell it's been a while since that PR 😄 - I guess we should remove it then! |
| # - handle :dl properly, we cannot use Markdown for this, since it cannot be represented | ||
| # using pure Markdown. We need to insert HTML directly. | ||
| # At the moment, we treat :dl as :ol |
There was a problem hiding this comment.
We should be able to do that, I think Vitepress accepts pure HTML. I'm just not sure if the Markdown will still be picked up. We'll have to test but that can be done later.
Builds upon #117
There are still (lots) of todos, but this seems to be working. I would suggest to get this in.
Edit: Tagging a version containing this would be appreciated. Then I can test it a bit more in the wild.