Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Allow named layers and some Misc Fixes #44

Closed
wants to merge 6 commits into from
Closed

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Jun 6, 2022

Example

julia> c = Chain(feature_extractor=Chain(Dense(2, 3, relu), BatchNorm(3)),
                 classifier=Chain(Dense(3, 2)))
Chain(
    feature_extractor = Chain(
        layer_1 = Dense(2 => 3, relu),  # 9 parameters
        layer_2 = BatchNorm(3),         # 6 parameters, plus 7
    ),
    classifier = Dense(3 => 2),         # 8 parameters
)         # Total: 23 parameters,
          #        plus 7 states, summarysize 48 bytes.

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #44 (78eb5fb) into main (7e8ce8e) will increase coverage by 0.05%.
The diff coverage is 44.04%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   45.07%   45.13%   +0.05%     
==========================================
  Files          13       13              
  Lines         945      955      +10     
==========================================
+ Hits          426      431       +5     
- Misses        519      524       +5     
Impacted Files Coverage Δ
src/Lux.jl 100.00% <ø> (ø)
src/adapt.jl 0.00% <0.00%> (ø)
src/layers/display.jl 0.00% <0.00%> (ø)
src/layers/normalize.jl 34.28% <0.00%> (ø)
src/utils.jl 46.98% <20.00%> (ø)
src/layers/basic.jl 38.65% <27.58%> (-0.41%) ⬇️
src/core.jl 56.52% <41.66%> (-3.95%) ⬇️
src/nnlib.jl 61.68% <45.45%> (ø)
src/autodiff.jl 48.00% <83.33%> (+5.77%) ⬆️
src/layers/conv.jl 47.11% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e8ce8e...78eb5fb. Read the comment docs.

@avik-pal avik-pal added the enhancement New feature or request label Jun 29, 2022
@avik-pal
Copy link
Member Author

Closing this since, most features have been pulled into different PRs (already in main). We still need to work on named layers for container types.

@avik-pal avik-pal closed this Jun 29, 2022
@avik-pal avik-pal deleted the ap/named_layers branch September 18, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant