Allow searching group members by username #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs #8 Signed-off-by: Knut Ahlers <knut@ahlers.me>
|
You are fast, I almost made a exactly same PR. |
|
As you wanted to suggest the same change: Does this work for you? If so I'd go ahead and merge it into master to release it… |
|
Yes, it worked. Please go ahead merge it. Thanks very much!
Charles
…On Thu, Jul 26, 2018 at 3:02 AM Knut Ahlers ***@***.***> wrote:
As you wanted to suggest the same change: Does this work for you? If so
I'd go ahead and merge it into master to release it…
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AE6v-IufT4pKc95ksGMf9MQwwVZT1XT0ks5uKZO5gaJpZM4VgzNi>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to use the specified
username_attributein a search for group members. This can especially be useful in case theuidis used as theusername_attributeand also inmemberoruniqueMemberattribute of groups instead of the DN.