-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#85] Allow to customize secret expiry #93
Conversation
Luzifer
commented
Jun 26, 2023
•
edited
Loading
edited
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
202d492
to
b6bc052
Compare
Signed-off-by: Knut Ahlers <knut@ahlers.me>
b6bc052
to
f22b67b
Compare
This looks really good. |
Signed-off-by: Knut Ahlers <knut@ahlers.me>
I could do some logic to derive the translation strings to be used from the seconds values and then it would be possible to specify them… 🤔
Indeed the time is displayed in browser local time… The API passes UTC to the browser. |
OK, maybe I am not clear what the list of values would be in the drop down. Can we specify a number and a unit ? with a max value enforced at startup. |
Yeah I did get what your intention was. Have a look at the README changes in the last commit… |
Signed-off-by: Knut Ahlers <knut@ahlers.me>
e728673
to
1641e38
Compare
I see, yes, that looks fine |
Signed-off-by: Knut Ahlers <knut@ahlers.me>
I just tested, this is outstanding. Could you please document how would we access that custom expiration when creating the secret via automation - ie curl call to OTS API ? Many thanks. |
That has been added to the API documentation: operation/createSecret - i.e.
|