-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loop over targets of all hosts #193
Conversation
Thanks for the contribution, can you check the linter? I'll test it this week as well. |
4c3a251
to
dde773e
Compare
The linter should be fixed now. |
@s-diez so the problem was if you add multiple targets, it would only check the first host? |
Exactly. These are the metrics from Current main branch:
With my changes:
|
Thank you! 🙏 I see I screwed this up with the refactoring. Do you think we can add an additional test? |
Looking into it. Looks like it should be testable. |
@till Thanks for the project and the fast responses |
Hi,
the refactor commit e88b79f contains an error and only iterates over the targets of the first resolved hostname. This can easily be tested with
make run-dev
. I hope the somewhat larger refactoring is fine with you.