-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ui/admin init #37
base: master
Are you sure you want to change the base?
Ui/admin init #37
Conversation
admin/src/store/modules/counter.js
Outdated
@@ -0,0 +1,45 @@ | |||
const state = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
counter
is redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
import _keyBy from 'lodash/keyBy' | ||
import {getAllNotifications} from '@/api/notifications' | ||
|
||
export const FOO = 'setNotifications'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why FOO
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was an example, removed that const
* Helper function to log Axios error in dev tools | ||
* @param {AxiosError} error | ||
*/ | ||
function logError(error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you already have the same functionality in admin/src/api/connections.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed from connections.js
No description provided.