Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui/admin init #37

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Ui/admin init #37

wants to merge 12 commits into from

Conversation

bheptinh
Copy link
Contributor

@bheptinh bheptinh commented Jun 4, 2019

No description provided.

@@ -0,0 +1,45 @@
const state = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

counter is redundant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

import _keyBy from 'lodash/keyBy'
import {getAllNotifications} from '@/api/notifications'

export const FOO = 'setNotifications';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why FOO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was an example, removed that const

* Helper function to log Axios error in dev tools
* @param {AxiosError} error
*/
function logError(error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you already have the same functionality in admin/src/api/connections.js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed from connections.js

@tmorozov tmorozov removed their request for review January 15, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants