This repository has been archived by the owner on Dec 25, 2023. It is now read-only.
WebAuthn.js does not work on older Safari versions #380
Labels
duplicate
This will not be worked on
Comments
nicokaiser
added a commit
to nicokaiser/Lychee-front
that referenced
this issue
Jan 28, 2023
|
This definitively affects iOS 12 (which was just recently updated with a security fix, so it is still around on some older devices), but also iOS/iPadOS 15 (which could be updated to iOS 16). There are some other things that break on "older" browsers, like the "overflow: clip" CSS property and the use of the ResizeObserver (#382), but I'll address these in another PR. |
nicokaiser
added a commit
to nicokaiser/Lychee-front
that referenced
this issue
Jan 30, 2023
Although probably the 3rd-party folder should be excluded from Prettier because it is, well, 3rd-party.
nicokaiser
added a commit
to nicokaiser/Lychee-front
that referenced
this issue
Feb 9, 2023
This requires WebAuthn.js not to be included in the blade templates, as it is already in frontend.js.
nicokaiser
added a commit
to nicokaiser/Lychee-front
that referenced
this issue
Feb 9, 2023
nicokaiser
added a commit
to nicokaiser/Lychee-front
that referenced
this issue
Feb 9, 2023
Although probably the 3rd-party folder should be excluded from Prettier because it is, well, 3rd-party.
nicokaiser
added a commit
to nicokaiser/Lychee-front
that referenced
this issue
Feb 9, 2023
This requires WebAuthn.js not to be included in the blade templates, as it is already in frontend.js.
ildyria
pushed a commit
that referenced
this issue
Mar 8, 2023
* Add WebAuthn.js and add to gulpfile (#380) * Fix Prettier formatting of WebAuthn.js (#380) Although probably the 3rd-party folder should be excluded from Prettier because it is, well, 3rd-party. * Add WebAuthn.js to frontend.js (#380) This requires WebAuthn.js not to be included in the blade templates, as it is already in frontend.js. * Compile WebAuthn.js into frontend.js --------- Co-authored-by: Nico Kaiser <nico@kaiser.me>
|
Duplicate of LycheeOrg/Lychee#1710 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is a copy of Lychee#1710
Since (about) version 4.7, Lychee does not work in older Safari browsers. Safari <= 13 is present on older iOS versions, and most probably some older android devices are also affected.
The culprit seems to be the new WebAuthn.js, which uses private class methods, and which is directly committed into the dist folder (and thus not being transpiled by the Babel task in Lychee-front.
Has this been a deliberate choice, or should the files in dist also be somewhere else and included in the transpilation step?
I‘d happy to help with a PR, but am not yet familiar with the interweaved structure of Lychee and Lychee-front…
The text was updated successfully, but these errors were encountered: