Create the db tables with InnoDB storage engine

[miklos-szel]

Since the integrity of the photos_table and the rest of the tables is vital for running Lychee I suggest moving to the InnoDB storage engine.

Using MyISAM is contraindicated as it's not crash safe(one can lose data when the under
lying database crashes) and it only supports table level locking(backup will cause longer lock).
The InnoDB is a modern storage engine that uses doublewrite buffer and redo log to achieve durability and crash safety.

Changing the storage engine doesn't need any application code changes.

The existing tables can be converted with
ALTER TABLE x engine=InnoDB;

This is a locking operation, but it won't take longer than a couple of seconds for a table with 10.000 rows, somebody with a really large (1 million photos) deployment might want to use pt-osc if having a downtime is not possible.

[ildyria]

Actually this is already solved in the V4.

[ildyria]

Rather than modifying the table at creation, can you make an "update patch" ?
eg. https://github.com/LycheeOrg/Lychee/blob/master/php/database/update_030209.php

[miklos-szel]

@ildyria awesome!

I can make an 'update patch' for sure! Should I patch the file you linked or create a new one for a future version ( like: update_030210.php for 3.2.10?)

[ildyria]

I can make an 'update patch' for sure! Should I patch the file you linked or create a new one for a future version ( like: update_030210.php for 3.2.10?)

With the current upgrade process of Lychee, if you change update_030209.php then it will never be executed to current users doing a git pull. So update_030210.php is needed yes. 👍