Skip to content
This repository has been archived by the owner on May 3, 2021. It is now read-only.

Public search #262

Merged
merged 7 commits into from
Jun 16, 2019
Merged

Public search #262

merged 7 commits into from
Jun 16, 2019

Conversation

kamil4
Copy link
Contributor

@kamil4 kamil4 commented May 30, 2019

Follow-up PR on #261.

Cleaned up, plugged the leaks, brought up to date with the latest changes to the front end.

Should be ready for merge.

copperschnack and others added 4 commits May 16, 2019 17:51
Also search through Unsorted if logged in.
Don't leak photos from hidden or password-protected photos albums.
Don't leak hidden albums.
Don't leak thumbs from password-protected albums.
Sync the album thumb code to correctly handle thumb order, video thumbs.
@kamil4 kamil4 requested review from ildyria and d7415 May 30, 2019 04:31
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested the SQL request but it looks fine.
However this comment needs to be fixed. 😆

php/Modules/Session.php Outdated Show resolved Hide resolved
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also version.md need to be changed.

@ildyria ildyria merged commit 45934db into master Jun 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the public-search branch June 16, 2019 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants