Skip to content
This repository has been archived by the owner on Dec 25, 2023. It is now read-only.

Album View not updated when moving images to a different (sub)folder #63

Closed
SerenaButler opened this issue Mar 9, 2019 · 6 comments · Fixed by #70 or #85
Closed

Album View not updated when moving images to a different (sub)folder #63

SerenaButler opened this issue Mar 9, 2019 · 6 comments · Fixed by #70 or #85
Assignees
Labels
bug Something isn't working

Comments

@SerenaButler
Copy link

  • Created a subalbum
  • Moved the first approx. 10 images to the subalbum
  • Get back to the Album view
  • Space of the moved images is "empty"

image

@ildyria
Copy link
Member

ildyria commented Mar 9, 2019

I guess this implies we need a recomputation of the position of the images.

@SerenaButler SerenaButler changed the title Album View not updatetd when moving images to a different (sub)folder Album View not updated when moving images to a different (sub)folder Mar 9, 2019
@ildyria ildyria transferred this issue from LycheeOrg/Lychee Apr 9, 2019
@ildyria ildyria added the bug Something isn't working label Apr 9, 2019
@kamil4 kamil4 added the question Further information is requested label Apr 12, 2019
@kamil4
Copy link
Contributor

kamil4 commented Apr 12, 2019

I'm having trouble reproducing it. Could you elaborate on the steps? Here's what I don't understand:

Step 1: Created a subalbum. That switches the view to that newly created subalbum, right?

Step 2: Moved the first approx. 10 images to the subalbum. How do you do that? I'm not aware of any way to move images from another album to the currently displayed one -- am I missing something? Do you exit the subalbum between steps 1 and 2? Also, do you move the images in bulk or one by one? Does it make a difference that it's 10 and not just 1 or 2?

Step 3: Get back to the Album view. Get back from where? Were you in the subalbum in Step 2 then? How did you move them then? 😲

@SerenaButler
Copy link
Author

@kamil4 I can't reproduce it either anymore ... and I can't remember exactly the behaviour at this time but I think it after you moved images you were refered to album the images where moved too. This behaviour is now different. So I think we can close this here.

@kamil4 kamil4 removed the question Further information is requested label Apr 14, 2019
@kamil4 kamil4 closed this as completed Apr 14, 2019
@kamil4
Copy link
Contributor

kamil4 commented Apr 15, 2019

I managed to produce this effect after all... though not for Move, but for Delete. Anyway, will be fixed in my next PR...

@SerenaButler
Copy link
Author

SerenaButler commented Apr 18, 2019

It's still kinda there with albums... :-( So guess we need to reopen.

Movin image:

image

Next image will be shown:

image

Going back to the album - see the gap:

image

@kamil4
Copy link
Contributor

kamil4 commented Apr 18, 2019

Right, so it still doesn't rejustify when Move or Delete is invoked from the photo view. Should be easy enough to fix...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
3 participants