Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests from Lychee releases to reduce size #481

Closed
essembeh opened this issue Apr 18, 2020 · 3 comments
Closed

Remove tests from Lychee releases to reduce size #481

essembeh opened this issue Apr 18, 2020 · 3 comments

Comments

@essembeh
Copy link

Detailed description of the problem

Lychee-v3.2.16.zip was 583K, Lychee-v4.0.0.zip is 45M.
Taking a look to the zip content, some test files are present:
Lychee-v4.0.0/tests/Feature: 20,2 MiB
Lychee-v4.0.0/vendor/php-ffmpeg/php-ffmpeg/tests/files: 9,6 MiB

Maybe the build shouldn't contain these huge files?
@d7415
Copy link
Contributor

d7415 commented Apr 18, 2020

One of the disadvantages of frameworks :( I agree that we probably don't need to include the tests in the release .zip though.

@d7415 d7415 changed the title Lychee v4 app size is over 45MB Remove tests from Lychee releases to reduce size Apr 18, 2020
@ildyria
Copy link
Member

ildyria commented Apr 18, 2020

@essembeh nicely spotted for the test files.

@d7415 d7415 closed this as completed in 45c8f74 Apr 18, 2020
@d7415
Copy link
Contributor

d7415 commented Apr 18, 2020

@essembeh Thanks!

This was referenced Apr 19, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ildyria @essembeh @d7415