Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Display version #485

Closed
ildyria opened this issue Apr 19, 2020 · 1 comment · Fixed by #490
Closed

[Enhancement] Display version #485

ildyria opened this issue Apr 19, 2020 · 1 comment · Fixed by #490
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ildyria
Copy link
Member

ildyria commented Apr 19, 2020

If one go to Diagnostic currently, this is what we see:

    System Information
    --------------
    Lychee-front Version:      4.0.0
    Lychee Version (git):      49d5862 (master) - Up to date (3 minutes ago).
    DB Version:                040001
    System:                    Linux
    PHP Version:               7.4
    MySQL Version:             10.3.22-MariaDB-1
    
    Imagick:                   1
    Imagick Active:            1
    Imagick Version:           1690
    GD Version:                2.2.5

The problem is when doing the update from the GUI the Lychee-front version is not correct anymore (even if up to date) because we do not update the sub module.

The second problem is in the case of the release, the Lychee-front version is not available.
We should hide this (currently it is asking to do git submodule init ; git submodule update).

The third problem is in the case of the release, we should make the distincting between the version used as released (get the data from version.md) and the version used when using git.

@ildyria ildyria added the enhancement New feature or request label Apr 19, 2020
@ildyria ildyria modified the milestone: v4.1.x Apr 19, 2020
@ildyria ildyria added the good first issue Good for newcomers label Apr 19, 2020
@LudovicRousseau
Copy link

I just installed Lychee 4.0.1 from the .zip file and I have:

    --------------
    Lychee-front Version:      -
    Lychee Version (git):      No git data found. Probably installed from release or could not read .git

This is not really helpful.

I also note that I still have version 4.0.0 (and not 4.0.1) if I select "À propos de Lychee" or in the login dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants