Moved unit tests for root album into separate class #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
reviewed
Jul 24, 2022
| ): TestResponse { | ||
| $response = $this->testCase->postJson('/api/Albums::get'); | ||
| $response->assertStatus($expectedStatusCode); | ||
| if ($assertSee) { |
There was a problem hiding this comment.
Good thing that phpstan is not parsing those files. 😆
There was a problem hiding this comment.
Yes, I had the exact same though. I also inclined to write if ($asserSee !== null), but this is copy & paste from the other files and then I decided to keep it consistent. At some point in the future I would like to include the tests into PHPStan, but not now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1414 I noticed that we do not have a test class which collects all API calls to the root album in the same way as we have for albums and photos. So far we only have had a method to call
Albums::getas part of the (normal) albums test, but it also has been quite different in style from the typical methods we have. As I am going to need more API calls to the root album in #1414, I first want to remedy this situation.