Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix complaints in Diagnostics when no migrations has been run #1990

Merged
merged 3 commits into from Aug 24, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Aug 24, 2023

Fixes complaint seen in #1988

Output of the diagnostics [REQUIRED]

/crashplan/www/lychee# php artisan lychee:diagnostics

In Connection.php line 795:

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'may_administrate' in 'where clause' (Connection: mysql, >SQL: select count(*) as aggregate
from users where may_administrate = 1)

In Connection.php line 416:

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'may_administrate' in 'where clause'

Basically skip any check that requires a DB interaction.

@ildyria ildyria requested a review from a team August 24, 2023 15:59
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Aug 24, 2023
@ildyria ildyria added this to the 4.11.1 milestone Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1990 (af2c583) into master (12bd6d4) will increase coverage by 1.82%.
The diff coverage is 50.00%.

Additional details and impacted files

@ildyria ildyria merged commit d7d0b5f into master Aug 24, 2023
29 checks passed
@ildyria ildyria deleted the fix-crash-diagnostic-no-users branch August 24, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants