Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better diagnostics for APP_URL and LYCHEE_UPLOAD_URL #2105

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Better diagnostics for APP_URL and LYCHEE_UPLOAD_URL #2105

merged 2 commits into from
Dec 26, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Dec 26, 2023 •
edited

Miss configurations in .env produce issues. Lets give the tools to debug them already at the diagnostic step.

Fixes #2102
Fixes #2103

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Dec 26, 2023
@ildyria ildyria added this to the 5.0.1 milestone Dec 26, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 26, 2023 •
edited

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (97b5e96) 85.87% compared to head (7c15063) 85.66%.
Report is 1 commits behind head on master.

Additional details and impacted files

@ildyria ildyria changed the title Better diagnostics to solve #2102 and #2103 Better diagnostics for APP_URL and LYCHEE_UPLOAD_URL Dec 26, 2023
@ildyria ildyria merged commit a4cf55b into master Dec 26, 2023
33 checks passed
@ildyria ildyria deleted the fix-2103-2102 branch December 26, 2023 18:38
@ildyria ildyria mentioned this pull request Dec 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.

All pictures reference localhost instead of server name v5 - Selected image not shown after upgrading to 5.0
2 participants
@ildyria @qwerty287