Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid more issues because people can't read release notes... #2124

Merged
merged 2 commits into from Dec 30, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Dec 28, 2023

image

the class="hidden" will automatically hide this message if css is loaded correctly. 😎

@ildyria ildyria added this to the 5.0.3 milestone Dec 28, 2023
@ildyria ildyria requested a review from a team December 28, 2023 16:23
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33354a2) 85.94% compared to head (c9176e8) 85.58%.

Additional details and impacted files

@d7415
Copy link
Contributor

d7415 commented Dec 28, 2023

This feels like a lot to include that should never be seen, but I can see why.

I'm also not super convinced by the inline styles, but they are enabled in our CSP, so they shouldn't break anything.

@ildyria ildyria merged commit 98e6010 into master Dec 30, 2023
33 checks passed
@ildyria ildyria deleted the make-more-dumb-proof branch December 30, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants