Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom.js not being loaded #2170

Merged
merged 1 commit into from Jan 5, 2024
Merged

Fix custom.js not being loaded #2170

merged 1 commit into from Jan 5, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 5, 2024

Fixes #2147

@ildyria ildyria requested a review from a team January 5, 2024 09:49
@ildyria ildyria self-assigned this Jan 5, 2024
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 5, 2024
@ildyria ildyria added this to the 5.0.3 milestone Jan 5, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a968352) 50.65% compared to head (35cd7d8) 85.61%.
Report is 1 commits behind head on master.

Additional details and impacted files

d7415
d7415 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, looks reasonable.

@ildyria ildyria merged commit c666927 into master Jan 5, 2024
33 checks passed
@ildyria ildyria deleted the fix-custom-js branch January 5, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees

@ildyria ildyria

Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
5.0.3
Development

Successfully merging this pull request may close these issues.

Custom JS not being loaded
2 participants
@ildyria @d7415