Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upload on smart albums #2218

Merged
merged 1 commit into from Jan 20, 2024
Merged

Fix upload on smart albums #2218

merged 1 commit into from Jan 20, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 20, 2024 •
edited

Fixes #2211

And remove dead code on upload from server.

@ildyria ildyria requested a review from a team January 20, 2024 14:03
@ildyria ildyria added Review: easy Easy review expected: probably just need a quick to go through. Livewire Only Changes that impact Livewire front-end only labels Jan 20, 2024
@ildyria ildyria self-assigned this Jan 20, 2024
@ildyria ildyria added this to the 5.1.1 milestone Jan 20, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2024 •
edited

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (129ea12) 85.82% compared to head (2ea5de1) 85.61%.
Report is 1 commits behind head on master.

Additional details and impacted files

@ildyria ildyria merged commit b6ee379 into master Jan 20, 2024
33 checks passed
@ildyria ildyria deleted the plus-menu-in-smart-albums branch January 20, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees

@ildyria ildyria

Labels
Livewire Only Changes that impact Livewire front-end only Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
5.1.1
Development

Successfully merging this pull request may close these issues.

Plus menu is not available in smart albums
2 participants
@ildyria @qwerty287