Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix title not being updated #2225

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fix title not being updated #2225

merged 1 commit into from
Jan 22, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 21, 2024

Fixes #2173

@ildyria ildyria requested a review from a team January 21, 2024 13:49
@ildyria ildyria added Review: easy Easy review expected: probably just need a quick to go through. Livewire Only Changes that impact Livewire front-end only labels Jan 21, 2024
@ildyria ildyria self-assigned this Jan 21, 2024
@ildyria ildyria added this to the 5.1.1 milestone Jan 21, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fc6c10) 86.41% compared to head (88b1989) 86.12%.

Additional details and impacted files

kamil4
kamil4 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@kamil4 kamil4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not tested).

@ildyria ildyria merged commit d1c2aec into master Jan 22, 2024
33 checks passed
@ildyria ildyria deleted the fix-2173 branch January 22, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil4 kamil4 kamil4 approved these changes

Assignees

@ildyria ildyria

Labels
Livewire Only Changes that impact Livewire front-end only Review: easy Easy review expected: probably just need a quick to go through.
Projects
Lychee development
Status: Done
Milestone
5.1.1
Development

Successfully merging this pull request may close these issues.

Renaming pictures not visible until page is reloaded
2 participants
@ildyria @kamil4