Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymize the paths in the diagnostics #2226

Merged
merged 1 commit into from Jan 22, 2024
Merged

Anonymize the paths in the diagnostics #2226

merged 1 commit into from Jan 22, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 21, 2024

Similar to urls, just to make it easier for people to copy paste their diagnostics while preserving privacy.

@ildyria ildyria requested a review from a team January 21, 2024 14:33
@ildyria ildyria self-assigned this Jan 21, 2024
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 21, 2024
@ildyria ildyria added this to the 5.1.1 milestone Jan 21, 2024
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (6fc6c10) 86.41% compared to head (3ea29c4) 86.05%.

Additional details and impacted files

Copy link
Contributor

@kamil4 kamil4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not tested)

@ildyria ildyria merged commit 4687800 into master Jan 22, 2024
33 checks passed
@ildyria ildyria deleted the anonymizePaths branch January 22, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants