Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redirection for legacy links #2227

Merged
merged 3 commits into from Jan 22, 2024
Merged

Add redirection for legacy links #2227

merged 3 commits into from Jan 22, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 21, 2024

Fixes #2176

@ildyria ildyria requested a review from a team January 21, 2024 15:00
@ildyria ildyria self-assigned this Jan 21, 2024
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 21, 2024
@ildyria ildyria added this to the 5.1.1 milestone Jan 21, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2024 •
edited

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6fc6c10) 86.41% compared to head (af6545f) 86.10%.

❗ Current head af6545f differs from pull request most recent head 74ecc79. Consider uploading reports for the commit 74ecc79 to get more accurate results

Additional details and impacted files

kamil4
kamil4 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@kamil4 kamil4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not tested, but I really will need to test this one! 😄).

app/Http/Controllers/RedirectController.php Outdated Show resolved Hide resolved
resources/views/hook-redirection.blade.php Outdated Show resolved Hide resolved
ildyria and others added 2 commits January 22, 2024 08:29
@ildyria @kamil4
Update app/Http/Controllers/RedirectController.php
c422b04 
Co-authored-by: Kamil Iskra <kamil.01482@iskra.name>
@ildyria
WRTC:
74ecc79
@ildyria ildyria merged commit df9ac5a into master Jan 22, 2024
20 of 32 checks passed
@ildyria ildyria deleted the fixes-2176 branch January 22, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil4 kamil4 kamil4 approved these changes

Assignees

@ildyria ildyria

Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
Lychee development
Status: Done
Milestone
5.1.1
Development

Successfully merging this pull request may close these issues.

[backward comp] v5 broke v4 shared album URLs (using fragments) : provide hook for /gallery#albumID.
2 participants
@ildyria @kamil4