Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve codecov: use their interface #516

Merged
merged 3 commits into from May 3, 2020
Merged

improve codecov: use their interface #516

merged 3 commits into from May 3, 2020

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Apr 29, 2020

Minor, no need for review.
Will merge if passes.

@d7415
Copy link
Contributor

d7415 commented Apr 29, 2020

If we're piping their script in, is there a need to update the version in the repo (rather than deleting it)?

@sonarcloud
Copy link

sonarcloud bot commented May 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ildyria
Copy link
Member Author

ildyria commented May 3, 2020

If we're piping their script in, is there a need to update the version in the repo (rather than deleting it)?

I don't understand your question.

@d7415
Copy link
Contributor

d7415 commented May 3, 2020

If we're piping their script in, is there a need to update the version in the repo (rather than deleting it)?

I don't understand your question.

Doesn't apply any more. in the first commit you had Travis fetching the codecov script with curl, but also updated our copy. Now it's just using our copy.

@ildyria ildyria merged commit 6ad85c5 into master May 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the better-codecov branch May 3, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants